added asset_tag and fixed lint issues

.ansible-sign/sha256sum.txt

@@ -113,9 +113,9 @@ b5b6f74b58134869395c82833f5e88224183dd0638673cb35b4d96be179072eb  ServiceNowtick
 d8d966ccdf1e73840974c82ced8da6002e81ecd1c7a94250401f9d2441778dd0  ServiceNowticket_security.yml
 93f04b85096726d7e67b0cfa19564b940469e808fbba7bce6238276f119cabb5  ServiceNowuser_create.yml
 334fb3b18b3bbd7c3893d712ead7506eddc48d3a3cec54fd40efb04d8535eb1e  collections/requirements.yml
-51ad299cb34ed6d3aebddc79674e7fb1d3a52a2f5060d53f341199d7f0a77cbd  devfile.yaml
+610ad8bd6358a8413fd45bf95bc6ce4b19a491265a4d86e4502a0ad5d8ae3d03  devfile.yaml
 f8f63300d2a511a2497b34ee831c4bec65d79f7780d2cc52989c977e4018698b  roles/servicenow_catalog/tasks/main.yml
-e8f50f046002bcc0934611c8e75e6c2444876c20cd6ffc1b84670088e9b7cc84  roles/servicenow_catalog_create/tasks/main.yml
+ee48964111304a0741dcdad36426967a1784a923eba8dbea9622089072b7d52f  roles/servicenow_catalog_create/tasks/main.yml
 dca8e6b77670bfa74e7302585937d64975a04bd09381c126d683d73fa7fd94c5  roles/servicenow_change_request/defaults/main.yml
 1c8c3ab1069136518c7fc6ad8754ee63eb73935ad2a9aacfe0f0121e30bf0ed6  roles/servicenow_change_request/tasks/main.yml
 a3dc6c14a17f1d5b86f466016d23278f80b334c28b84a73d1671255af0cd57ac  roles/servicenow_change_request/tasks/servicenow_canceled.yml
@@ -124,8 +124,8 @@ a3dc6c14a17f1d5b86f466016d23278f80b334c28b84a73d1671255af0cd57ac  roles/servicen
 f24230fbcf3e3e8ead1a35ca1bc06ee6279cdd60180129a1d78e90dced09ce8f  roles/servicenow_change_request/tasks/servicenow_deleted.yml
 f3fff777c19e4539b6d639f3ac6d639d1bf55c177ed67366110aa6bc6b311137  roles/servicenow_change_request/tasks/servicenow_implement.yml
 a464004cbb41d95d683f7a25ae37a1813d17be673a1b2a834186ac123bd961fb  roles/servicenow_change_request_wait/defaults/main.yml
-c20e13cfafc1a0447893f3bababa15513a73bf25064235e001f746d6e2310e5c  roles/servicenow_change_request_wait/tasks/main.yml
-f343ccda9aeb24dfca122914f78de121e5ca8b8be1c6d18e0c39163ecc475d1e  roles/servicenow_cmdb/tasks/main.yml
+5c15d56df4f343e4cee23d1f94953b6ff9f524ada30033d0c488835bbdcea6eb  roles/servicenow_change_request_wait/tasks/main.yml
+a20257c1ae20239b6f847be6bed39917940e168a7839e7e09281099111c77cec  roles/servicenow_cmdb/tasks/main.yml
 70c16b04f073bd76d518d043e29db8b862d2b48d72ffa3ce9d61279e370efdc4  roles/servicenow_ticket/defaults/main.yml
 b8cab364bf2b85691fae7cf83f1340ae5e5b4fe0f6829068ab6955c924651412  roles/servicenow_ticket/tasks/main.yml
 fe2192caf1621560b49616cf159cee58ceace50035641059bc52d5ed4b2f62f5  roles/servicenow_ticket/tasks/servicenow_close.yml

.ansible-sign/sha256sum.txt.sig

@@ -1,14 +1,14 @@
 -----BEGIN PGP SIGNATURE-----
 
-iQGzBAABCAAdFiEE/bJvyFHKKJdaZDOLTiIiIXrUDNEFAmZDwKMACgkQTiIiIXrU
-DNEXxgv+Lu7I3vtXmijLDOirNA9+hxdgnWbFkdcYJxWb1h+BGN5Huxg2V6i02j8E
-vlGsG7PumD1PrDTCuZ0wU3bK0DZFrZUpveIwY0AbP1UGEuBs0LP6XgX4XbVduvr+
-WvAuk3dCX7PM+xJMY8ALMWkfzf2gqFOReWZTdRZPZj088WYI/mMt3V1TcAtXhLzS
-2vrlAPTi9CRfzklD5E0c/J0bSGkb58PE/qlhDl8pmO3e3Kdf1e6mXrsUSiI24cpT
-ZmcueVPT02jMk/AxEql9zcTWvGnIH2ymQyEyHbI1LhZNFzibP+zYthgp37DIqL1R
-ivMVCJU2bAuZIyJJIqzI/AfvXMyNCYyyyxjNu9vdaIvL7jKVrO8GmRAaC9A69YlB
-avUYVEJBgao/4CuijFQv2nOypn8aCB8vGykj9O4odn6lm0GJmuzCLlkKxl6VzxEz
-aZeAv+qam0SqbKHXLM07WhOAG3Yuuk9yygH3PLx1Iytnc52tQly7nptN1hK1y65n
-9DxgRRg9
-=AOL7
+iQGzBAABCAAdFiEE/bJvyFHKKJdaZDOLTiIiIXrUDNEFAmZHt34ACgkQTiIiIXrU
+DNFMJwv8DolUUJI/FpbizSc2DIYL4KuwVgKZbkV+TxMIsDDUp0l7f3XyAYWFzmc8
+0eUZytdztK9KFLFNc4BcLW71sQpLQMb0vAuE4fVpofRVOegreiV3OgtkvBQQCd4F
+aJIygcH5/Xiz+aL6RMVk+6nngGocIUYywiA1DPmGBX4Rm+QO9IUis6hzcbEcEOT1
+ArSZOKyBl91VLLnYe0cqrZ6jKUNoSfYlsOVRRQ6c393DHZmJw8JMZOg670KNb5Fb
+wlnupBB8okhg97s3QzJxeXAIdow19qb5xHRv/rFLsd7cBsPTrl3/0kt87eHRaC/H
+YSrMr/RCWpkiPlHL/j4XsO/sfbR320NykhVtAiT7M+Acs2ciySqQGSI9/Cm7D/vc
+KsUJmtYrt1ShDxhtt+Chj1bfusithGKaq9jOJSpttZbeC3+1Ts8AgQwtAhvHrvJ0
+UpRAJo/+C+ks51RPSNVSwGY5MonGe8IcFmBeYzrX/RED0C4ntbIfAHYJoQ4isKnx
+iWb+LW1w
+=YYW4
 -----END PGP SIGNATURE-----

devfile.yaml

@@ -3,8 +3,8 @@ metadata:
   name: ansible-snow-development
 components:
   - container:
-      args: ['tail', '-f', '/dev/null']
-      image: 'towerpah.shadowman.dev/devee:latest'
+      args: [tail, -f, /dev/null]
+      image: towerpah.shadowman.dev/devee:latest
       memoryRequest: 256M
       memoryLimit: 6Gi
       cpuRequest: 250m

roles/servicenow_catalog_create/tasks/main.yml

@@ -10,9 +10,9 @@
     resource: sc_category
     action: post
     data:
-      title: "Ansible Jobs"
-      sc_catalog: "Service Catalog"
-      description: "Jobs launced from AAP"
+      title: Ansible Jobs
+      sc_catalog: Service Catalog
+      description: Jobs launced from AAP
       active: true
   when: categoryresult.record | length == 0
 
@@ -27,22 +27,22 @@
     resource: sc_cat_item
     action: post
     data:
-      name: "Provision VM"
-      sc_catalogs: "Service Catalog"
-      category: "Ansible Jobs"
+      name: Provision VM
+      sc_catalogs: Service Catalog
+      category: Ansible Jobs
       active: true
-      short_description: "Deploy a new virtual machine"
+      short_description: Deploy a new virtual machine
   when: catalogitemresult.record | length == 0
 
 - name: Create Single Line Variable to enter VM Name
   servicenow.itsm.api:
     resource: item_option_new
     action: post
     data:
-      type: "Single Line Text"
-      cat_item: "Provision VM"
-      question_text: "What is your VM name?"
-      name: "vm_name"
+      type: Single Line Text
+      cat_item: Provision VM
+      question_text: What is your VM name?
+      name: vm_name
       active: true
       mandatory: true
       order: 100
@@ -53,10 +53,10 @@
     resource: item_option_new
     action: post
     data:
-      type: "Select Box"
-      cat_item: "Provision VM"
-      question_text: "Pick your OS"
-      name: "operating_system"
+      type: Select Box
+      cat_item: Provision VM
+      question_text: Pick your OS
+      name: operating_system
       order: 200
       active: true
       mandatory: true
@@ -67,15 +67,15 @@
     resource: question_choice
     action: post
     data:
-      type: "Select Box"
-      cat_item: "Provision VM"
-      question: "Pick your OS"
+      type: Select Box
+      cat_item: Provision VM
+      question: Pick your OS
       text: "{{ item.text }}"
       value: "{{ item.value }}"
       order: "{{ item.order }}"
   loop:
-    - { text: 'RHEL7', value: 'RHEL7', order: '100' }
-    - { text: 'RHEL8', value: 'RHEL8', order: '200' }
-    - { text: 'RHEL9', value: 'RHEL9', order: '300' }
-    - { text: 'Win2016', value: 'Win2016', order: '400' }
+    - { text: RHEL7, value: RHEL7, order: "100" }
+    - { text: RHEL8, value: RHEL8, order: "200" }
+    - { text: RHEL9, value: RHEL9, order: "300" }
+    - { text: Win2016, value: Win2016, order: "400" }
   when: catalogitemresult.record | length == 0

roles/servicenow_change_request_wait/tasks/main.yml

@@ -6,8 +6,8 @@
       servicenow.itsm.change_request:
         type: normal
         short_description: "{{ cr_description }}"
-        description: "{{ owner | default('Shadowman') }} requests {{ operating_system | default('') }} server in
-         {{ shadowman_provision_hypervisor | default('') }} with name {{ vm_name | default('') }} and environment {{ env | default('test') }}"
+        description: "{{ owner | default('Shadowman') }} requests {{ operating_system | default('') }} server in {{ shadowman_provision_hypervisor | default('') }}
+          with name {{ vm_name | default('') }} and environment {{ env | default('test') }}"
         priority: high
         risk: moderate
         impact: low
@@ -33,8 +33,8 @@
         password: "{{ EMAIL_PASSWORD }}"
         port: "{{ EMAIL_PORT }}"
         subject: Approval request for ServiceNow Change Request {{ request.record.number }}
-        body: "You have a new CR Approval request. Please click on this URL to approve:
-          {{ lookup('env', 'SN_HOST') }}nav_to.do?uri=change_request.do?sysparm_query=number={{ request.record.number }}"
+        body: "You have a new CR Approval request. Please click on this URL to approve: {{ lookup('env', 'SN_HOST') }}nav_to.do?uri=change_request.do?sysparm_query=number={{
+          request.record.number }}"
         from: tower@shadowman.dev
         to: "{{ to_email }}"
       delegate_to: localhost

roles/servicenow_cmdb/tasks/main.yml

@@ -2,6 +2,7 @@
 - name: Update SNOW CMDB
   servicenow.itsm.configuration_item:
     state: "{{ status }}"
+    asset_tag: "{{ owner }}"
     name: "{{ inventory_hostname }}"
     ip_address: "{{ ip_addr | default(omit) }}"
     sys_class_name: cmdb_ci_server