Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add DataSpannerTest annotation #2416

Closed
wants to merge 1 commit into from
Closed

Add DataSpannerTest annotation #2416

wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Jun 5, 2020

Currently this configuration is required in order to test a Spanner repository. This PR help to improve that configuration in some way. But previously required some commands to be executed

gcloud config configurations create emulator

gcloud config set auth/disable_credentials true

gcloud config set project test-project

gcloud config set api_endpoint_overrides/spanner http://localhost:9020/

gcloud spanner instances create test-instance --config=emulator-config --description="Test Instance" --nodes=1

gcloud spanner databases create test-database --instance test-instance --ddl "CREATE TABLE TestTable (key INT64, value STRING(MAX)) PRIMARY KEY (key)"

In order to improve from the test perspective, I think #2357 will help a lot and may this proposal will do the same. Also would like to think about how these initiatives will integrate with testcontainers, for example, I have a PR https://github.com/testcontainers/testcontainers-java/pull/2690/files which will use docker sdk but it requires additional installation in order to use alpine images so there is an issue requesting images for the other emulators, something similar to spanner.

The same can be done for datasotre, firestore and I already have something in progress but looks pretty similar. Also, considering pubsub but thinking more about it.

See gh-2281

@eddumelendez
Copy link
Contributor Author

/cc @saturnism

@ttomsu ttomsu requested review from dmitry-s and saturnism June 10, 2020 14:14
@dmitry-s
Copy link
Contributor

@eddumelendez thanks for your contribution! We have redesigned our test-support module and this PR will be very useful when we start working on it.

@meltsufin meltsufin added awaiting waiting for something external backlog and removed awaiting waiting for something external labels Jul 14, 2020
@eddumelendez eddumelendez closed this by deleting the head repository Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants