-
Notifications
You must be signed in to change notification settings - Fork 693
Make Pub/Sub integration tests less flaky #2546
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
Codecov Report
@@ Coverage Diff @@
## master #2546 +/- ##
============================================
- Coverage 81.48% 74.28% -7.21%
+ Complexity 2389 2162 -227
============================================
Files 267 267
Lines 7762 7762
Branches 803 803
============================================
- Hits 6325 5766 -559
- Misses 1098 1626 +528
- Partials 339 370 +31
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an improvement. We should still make topic/subscription names random to prevent flakes from multiple simultaneous builds.
The first one already uses random topic/subscription. The second is a sample test, which we can definitely improve by making the topic and subscription configurable. The same goes for a few other samples like the |
* Make PubTemplateIntegrationTests less flaky
Yes, Travis filed #2533. |
* Make PubTemplateIntegrationTests less flaky * Make ReactiveReceiverApplicationTest less flaky
* Make PubTemplateIntegrationTests less flaky * Make ReactiveReceiverApplicationTest less flaky
No description provided.