#2839: Raise error if ignore_directives=False but ignore_comments=True

src/psyclone/psyir/frontend/fortran.py

@@ -83,6 +83,11 @@ def __init__(self, free_form: bool = True, ignore_comments: bool = True,
         if not self._parser:
             self._parser = ParserFactory().create(std="f2008")
         self._free_form = free_form
+        if ignore_comments and not ignore_directives:
+            raise ValueError(
+                "Setting ignore_directives to False will only have an effect if"
+                "ignore_comments is also set to False"
+            )
         self._ignore_comments = ignore_comments
         self._processor = Fparser2Reader(ignore_directives,
                                          last_comments_as_codeblocks,

src/psyclone/tests/psyir/frontend/fortran_test.py

@@ -275,3 +275,12 @@ def test_fortran_psyir_from_file(fortran_reader, tmpdir_factory):
             assert node.preceding_comment == "Comment on assignment"
         else:
             assert node.preceding_comment == ""
+
+    # Check that the following combination raises an error
+    with pytest.raises(ValueError) as err:
+        FortranReader(ignore_comments=True, ignore_directives=False)
+    msg = (
+        "Setting ignore_directives to False will only have an effect if"
+        "ignore_comments is also set to False"
+    )
+    assert msg in str(err.value)