-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #2638) add new linkspector workflow #2639
Conversation
Addresses the persistent false positive in the link checking by moving to 'linkspector' instead of markdown link checker. They are both running in parallel in this PR but once the reviewer is happy I propose removing 'markdown-link-checker' altogether. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 351 351
Lines 48396 48396
=======================================
Hits 48331 48331
Misses 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter I agree we should move to the new tool if it's better and the new preferred way. Also I agree in removing the old check (and its config file) in this PR.
All green and lovely now. I remembered that I needed to update the Dev Guide so I've done that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter All comments have been addressed, the CI issues are gone and the documentation has been updated. This is ready to merge.
No description provided.