Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #2638) add new linkspector workflow #2639

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Conversation

arporter
Copy link
Member

@arporter arporter commented Jul 1, 2024

No description provided.

@arporter arporter self-assigned this Jul 1, 2024
@arporter
Copy link
Member Author

arporter commented Jul 1, 2024

Addresses the persistent false positive in the link checking by moving to 'linkspector' instead of markdown link checker. They are both running in parallel in this PR but once the reviewer is happy I propose removing 'markdown-link-checker' altogether.
One for @hiker, @LonelyCat124, @TeranIvy or @sergisiso.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (98e15d6) to head (89b9dec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         351      351           
  Lines       48396    48396           
=======================================
  Hits        48331    48331           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter I agree we should move to the new tool if it's better and the new preferred way. Also I agree in removing the old check (and its config file) in this PR.

.github/workflows/linkspector.yml Outdated Show resolved Hide resolved
.github/workflows/linkcheck.yml Outdated Show resolved Hide resolved
.github/workflows/linkcheck.yml Outdated Show resolved Hide resolved
@arporter
Copy link
Member Author

arporter commented Jul 1, 2024

All green and lovely now. I remembered that I needed to update the Dev Guide so I've done that now.
Ready for another look.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter All comments have been addressed, the CI issues are gone and the documentation has been updated. This is ready to merge.

@sergisiso sergisiso merged commit 4d10caa into master Jul 1, 2024
12 checks passed
@sergisiso sergisiso deleted the 2638_linkspector branch July 1, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants