Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #1664) Add ACCWaitDirective and async keyword on kernels, enter data, parallel #2664

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
27d51f9
#2070 ACC async_queue via mixins
svalat Sep 11, 2023
701f728
Merge branch 'master' into feature/acc-wait-directive
arporter Sep 14, 2023
833e1f7
Merge branch 'master' into 1664_acc_wait_dir
arporter Jul 18, 2024
918e07b
#1664 mv new functionality over to new class location
arporter Jul 18, 2024
edf9917
#1664 fix some import errors after merge
arporter Jul 18, 2024
b9de9fe
#1664 more fixes following merge
arporter Jul 18, 2024
da4f5b5
#1664 fix linting errors
arporter Jul 18, 2024
4848cd2
Merge branch 'master' into 1664_acc_wait_dir
arporter Aug 8, 2024
cda76d4
Merge branch 'master' into 1664_acc_wait_dir
arporter Nov 22, 2024
2ef718b
#1664 update tests
arporter Nov 22, 2024
4974eda
Merge branch 'master' into 1664_acc_wait_dir
arporter Nov 22, 2024
b351d84
#1664 tidy and rationalise checking code
arporter Nov 22, 2024
1be11c3
updated for coverage
Nov 25, 2024
48930fd
u
Nov 25, 2024
ac7783d
fixed generation of documentation
Nov 25, 2024
81b9038
updates for CI
Nov 26, 2024
aefa05d
removed obsolete line => 100% coverage
Nov 26, 2024
aab90db
Merge branch 'master' into 1664_acc_wait_dir
arporter Dec 19, 2024
c8a2629
#1664 begin adding new clause [skip ci]
arporter Dec 19, 2024
1c5a6a7
Merge branch 'master' into 1664_acc_wait_dir
arporter Jan 8, 2025
50ddb92
#1664 more reworking to use Clause [skip ci]
arporter Jan 9, 2025
2c677a2
#1664 fix linting [skip ci]
arporter Jan 9, 2025
c099396
#1664 fix tests
arporter Jan 10, 2025
31f0c07
Merge branch 'master' into 1664_acc_wait_dir
arporter Jan 10, 2025
1fb7c85
#1664 support DataNode for async queue and tidy docstrings
arporter Jan 10, 2025
8b4e0e9
#1664 fix lint
arporter Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/psyclone/f2pygen.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ class ACCDirective(Directive):
'loop').
'''
def __init__(self, root, line, position, dir_type):
self._types = ["parallel", "kernels", "enter data", "loop", "routine"]
self._types = [
"parallel", "kernels", "enter data", "loop", "routine",
"wait"
]
self._positions = ["begin", "end"]

super(ACCDirective, self).__init__(root, line, position, dir_type)
Expand Down
10 changes: 6 additions & 4 deletions src/psyclone/psyGen.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
# Modified by I. Kavcic and L. Turner, Met Office
# Modified by C.M. Maynard, Met Office / University of Reading
# Modified by J. Henrichs, Bureau of Meteorology
# Modified S. Valat, Inria / Laboratoire Jean Kuntzmann
# Modified M. Schreiber, Univ. Grenoble Alpes / Inria / Lab. Jean Kuntzmann
# -----------------------------------------------------------------------------

''' This module provides generic support for PSyclone's PSy code optimisation
Expand Down Expand Up @@ -2582,11 +2584,11 @@ class KernelArgument(Argument):
arguments as specified by the kernel argument metadata and the
kernel invocation in the Algorithm layer.

:param arg: information obtained from the metadata for this kernel \
argument.
:param arg: information obtained from the metadata for this kernel
argument.
:type arg: :py:class:`psyclone.parse.kernel.Descriptor`
:param arg_info: information on how this argument is specified in \
the Algorithm layer.
:param arg_info: information on how this argument is specified in
the Algorithm layer.
:type arg_info: :py:class:`psyclone.parse.algorithm.Arg`
:param call: the PSyIR kernel node to which this argument pertains.
:type call: :py:class:`psyclone.psyGen.Kern`
Expand Down
2 changes: 1 addition & 1 deletion src/psyclone/psyir/nodes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
ACCDirective, ACCLoopDirective, ACCEnterDataDirective,
ACCParallelDirective, ACCKernelsDirective, ACCDataDirective,
ACCUpdateDirective, ACCStandaloneDirective, ACCRegionDirective,
ACCRoutineDirective, ACCAtomicDirective)
ACCRoutineDirective, ACCAtomicDirective, ACCWaitDirective)
from psyclone.psyir.nodes.omp_directives import (
OMPDirective, OMPDoDirective, OMPParallelDirective,
OMPParallelDoDirective, OMPSingleDirective, OMPMasterDirective,
Expand Down
Loading
Loading