-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(closes #2676) Fix Nemo reproducibility issue #2679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 353 353
Lines 48806 48818 +12
=======================================
+ Hits 48741 48753 +12
Misses 65 65 ☔ View full report in Codecov by Sentry. |
@arporter This is ready to review. The integration tests all pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done for tracking this down Sergi. I think it's fine but it would be better if we could put the functionality in the transformations themselves rather than utils.py
, if that's possible?
Also, please could you tweak the nemo_tests.yml
file so that it fails with a better error when the results don't match?
Integration tests were all green. I'll check the Ref. Guide next time.
@arporter CI and integration test-permitting (which I just triggered), this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks for improving the error handling in the integration tests.
Ref. guide builds fine.
Integration tests were all green.
Will proceed to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I pressed the wrong button last time. This is ready to go!
Just to say, I checked performance too and it was all fine. |
No description provided.