Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(closes #2676) Fix Nemo reproducibility issue #2679

Merged
merged 12 commits into from
Aug 2, 2024
Merged

Conversation

sergisiso
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (2ce711d) to head (2cffc16).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2679   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         353      353           
  Lines       48806    48818   +12     
=======================================
+ Hits        48741    48753   +12     
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergisiso sergisiso changed the title (closes #2676) Fix integration test failures (closes #2676) Fix Nemo reproducibility issue Jul 30, 2024
@sergisiso
Copy link
Collaborator Author

@arporter This is ready to review. The integration tests all pass now.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for tracking this down Sergi. I think it's fine but it would be better if we could put the functionality in the transformations themselves rather than utils.py, if that's possible?
Also, please could you tweak the nemo_tests.yml file so that it fails with a better error when the results don't match?
Integration tests were all green. I'll check the Ref. Guide next time.

.github/workflows/lfric_test.yml Show resolved Hide resolved
examples/nemo/scripts/utils.py Outdated Show resolved Hide resolved
@sergisiso
Copy link
Collaborator Author

@arporter CI and integration test-permitting (which I just triggered), this is ready for another review.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for improving the error handling in the integration tests.
Ref. guide builds fine.
Integration tests were all green.
Will proceed to merge.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I pressed the wrong button last time. This is ready to go!

@arporter
Copy link
Member

arporter commented Aug 2, 2024

Just to say, I checked performance too and it was all fine.

@arporter arporter merged commit 4297270 into master Aug 2, 2024
12 checks passed
@arporter arporter deleted the 2676_fix_nemo_issues branch August 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants