Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2724 Updated version number to be 3.0.1-dev. #2818

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Dec 6, 2024

This doesn't fully fix 2724. MY understanding is that we first use -dev, then wait for feedback from Iva if we can switch to the automated way using setuptools_scm (which caused problems on some UK systems I Believe).

So, this only adds -dev for now

@hiker hiker changed the title #2724 Updated version number to be 3.0.0-dev. #2724 Updated version number to be 3.0.1-dev. Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (b60c53f) to head (1f3c485).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2818   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         357      357           
  Lines       49742    49742           
=======================================
  Hits        49686    49686           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiker
Copy link
Collaborator Author

hiker commented Dec 9, 2024

As discussed, update the version number to 3.0.1-dev (while we investigate if we can automate this). Note that both Sergi and I agreed that there is no need to call it 3.0.1-develop in order to be supported by spack, 'develop' is just the spack name that can be given to any branch.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiker This introduces the "-dev" change that we agreed and has passed all CI tests.

@hiker @arporter breaking convention I will merge without the changelog update as this seems a repo managing change (not functionality) and it will be reversed anyway for the next release. But let me know if you disagree as then I could add it later.

@sergisiso sergisiso merged commit 1e6b095 into master Dec 9, 2024
14 checks passed
@sergisiso sergisiso deleted the 2724_update_version_number_to_dev branch December 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants