[CHANGE] changed stream exports get to return err instead of bool

stream_exports.go

@@ -10,12 +10,12 @@ type streamExports struct {
 	*AccountData
 }
 
-func (s *streamExports) Get(subject string) (StreamExport, bool) {
+func (s *streamExports) Get(subject string) (StreamExport, error) {
 	se := s.getStreamExport(subject)
 	if se != nil {
-		return se, true
+		return se, nil
 	}
-	return nil, false
+	return nil, ErrNotFound
 }
 
 func (s *streamExports) AddWithConfig(e StreamExport) error {

tests/exports_test.go

@@ -80,8 +80,8 @@ func (t *ProviderSuite) Test_ExportTokenRequired() {
 	t.NoError(err)
 	t.True(service.TokenRequired())
 
-	stream, ok := a.Exports().Streams().Get("t.>")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.>")
+	t.NoError(err)
 	t.True(stream.TokenRequired())
 }
 
@@ -114,12 +114,12 @@ func (t *ProviderSuite) Test_ExportNameSubject() {
 	t.NoError(stream.SetName("ss"))
 	t.NoError(stream.SetSubject("st.>"))
 
-	_, ok := a.Exports().Streams().Get("t.>")
-	t.False(ok)
-	_, ok = a.Exports().Streams().GetByName("s")
+	_, err = a.Exports().Streams().Get("t.>")
+	t.ErrorIs(err, authb.ErrNotFound)
+	_, ok := a.Exports().Streams().GetByName("s")
 	t.False(ok)
-	_, ok = a.Exports().Streams().Get("st.>")
-	t.True(ok)
+	_, err = a.Exports().Streams().Get("st.>")
+	t.NoError(err)
 	_, ok = a.Exports().Streams().GetByName("ss")
 	t.True(ok)
 }
@@ -146,8 +146,8 @@ func (t *ProviderSuite) Test_ExportDescription() {
 	t.NoError(err)
 	t.Equal("desc", service.Description())
 
-	stream, ok := a.Exports().Streams().Get("t.>")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.>")
+	t.NoError(err)
 	t.Equal("desc", stream.Description())
 }
 
@@ -173,8 +173,8 @@ func (t *ProviderSuite) Test_ExportInfoURL() {
 	t.NoError(err)
 	t.Equal("https://service.com", service.InfoURL())
 
-	stream, ok := a.Exports().Streams().Get("t.>")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.>")
+	t.NoError(err)
 	t.Equal("https://stream.com", stream.InfoURL())
 }
 
@@ -200,8 +200,8 @@ func (t *ProviderSuite) Test_ExportAccountTokenPosition() {
 	t.NoError(err)
 	t.Equal(uint(2), service.AccountTokenPosition())
 
-	stream, ok := a.Exports().Streams().Get("t.*")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.*")
+	t.NoError(err)
 	t.Equal(uint(2), stream.AccountTokenPosition())
 }
 
@@ -272,10 +272,10 @@ func (t *ProviderSuite) Test_StreamExportCrud() {
 	t.NoError(err)
 	t.Len(a.Exports().Streams().List(), 1)
 
-	_, ok := a.Exports().Streams().Get("q.>")
-	t.True(ok)
+	_, err = a.Exports().Streams().Get("q.>")
+	t.NoError(err)
 
-	_, ok = a.Exports().Streams().GetByName("q")
+	_, ok := a.Exports().Streams().GetByName("q")
 	t.True(ok)
 
 	x, err := authb.NewStreamExport("x", "x.>")

tests/revocations_test.go

@@ -58,8 +58,8 @@ func (t *ProviderSuite) Test_ExportRevocationRequiresAccountToken() {
 	t.Len(revocations, 1)
 	t.Equal(ak.Public, revocations[0].PublicKey())
 
-	stream, ok := a.Exports().Streams().Get("t.>")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.>")
+	t.NoError(err)
 	revocations = stream.Revocations().List()
 	t.Len(revocations, 1)
 	t.Equal(ak.Public, revocations[0].PublicKey())
@@ -91,8 +91,8 @@ func (t *ProviderSuite) Test_ExportRevocationWildCardIsAllowed() {
 	t.Len(revocations, 1)
 	t.Equal("*", revocations[0].PublicKey())
 
-	stream, ok := a.Exports().Streams().Get("t.>")
-	t.True(ok)
+	stream, err = a.Exports().Streams().Get("t.>")
+	t.NoError(err)
 	revocations = stream.Revocations().List()
 	t.Len(revocations, 1)
 	t.Equal("*", revocations[0].PublicKey())

types.go

@@ -420,7 +420,7 @@ type StreamExports interface {
 	// AddWithConfig adds a copy of the specified configuration to the account
 	AddWithConfig(e StreamExport) error
 	// Get returns the StreamExport matching the subject or nil if not found
-	Get(subject string) (StreamExport, bool)
+	Get(subject string) (StreamExport, error)
 	// Delete deletes the StreamExport matching the subject
 	Delete(subject string) (bool, error)
 	// GetByName returns the StreamExport matching the specified name,