Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts goakt tests #482

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Reverts goakt tests #482

merged 2 commits into from
Jan 6, 2025

Conversation

jordan-rash
Copy link
Contributor

Tests added flake that needs to be further investigated

@jordan-rash
Revert "Use goakt testing framework (#478)"
ff933c4 
This reverts commit b0115bf.
Additional tests have added flake for unknown reason
@jordan-rash
revert goakt test
21f48fa 
Signed-off-by: Jordan Rash <jordan@synadia.com>
@jordan-rash jordan-rash requested a review from a team as a code owner January 6, 2025 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/synadia-io/nex/node/internal/actors 12.85% (-6.17%) 👎
Coverage by file

Changed unit test files

  • github.com/synadia-io/nex/node/internal/actors/agent_supervisor_test.go
  • github.com/synadia-io/nex/node/internal/actors/control_api_test.go
  • github.com/synadia-io/nex/node/internal/actors/mock_node_test.go

@jordan-rash jordan-rash mentioned this pull request Jan 6, 2025
Merged
@jordan-rash jordan-rash requested a review from bruth January 6, 2025 14:48
@jordan-rash jordan-rash mentioned this pull request Jan 6, 2025
Open
@jordan-rash jordan-rash merged commit 02418fa into main Jan 6, 2025
8 checks passed
@jordan-rash jordan-rash deleted the fix/revert_goakttest branch January 6, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruth bruth bruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-rash @bruth