Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add termination reason to request many #4

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Jarema
Copy link
Collaborator

@Jarema Jarema commented Jan 9, 2025

Request many can termination for many different reasons. This commit adds ability to retrieve information about the cause without complicating the API.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from piotrpio January 9, 2025 10:11
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Request many can termination for many different reasons.
This commit adds ability to retrieve information about the cause
without complicating the API.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the add-termination-reason-to-request-many branch from 282584d to f4756c1 Compare January 9, 2025 10:25
@Jarema Jarema merged commit b3e6599 into main Jan 9, 2025
12 checks passed
@Jarema Jarema mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants