Provide upgrade choices for stable and testing #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now upgrade-vagga.sh can upgrade either to stable or to testing versions of vagga depending on arguments. By default upgrade to stable version of vagga as testing version by definition may contain unexpected bugs and be unstable.
Allow upgrade_vagga command to receive arguments which define upgrade version: either testing or stable version of vagga. Argument is directly passed to the underlying command in virtualbox.
Describe --testing flag for upgrade_vagga command in README.rst. Also note that `vagga _box upgrade_vagga` will upgrade vagga to the latest stable version by default.
|
Looks good. But this PR will have to be postponed until I rebuild the virtualbox image (this isn't an automatic thing for many reasons). |
|
Sure. By the way, how can I rebuild the image locally for my own machine? |
|
Use packer and |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems weird that by default stable version of vagga is installed in vagga-box but all updates are for testing version of vagga. The aim of this PR is to fix that and allow upgrades between stable versions of vagga in vagga_box.
This PR introduces the following changes:
upgrade_vaggashell script can upgrade to either stable or testing version of vagga depending on command-line arguments passedupgrade_vaggaby default upgrades vagga to the latest stable version. The motivation for this is that by definition testing version may contain unknown and unexpected bugs, which should not be present (by definition) in the stable version.vagga _box upgrade_vaggapasses the first argument to the underlying shell script so the flags forupgrade_vaggacan be used.However still some help and clarification are needed. I have modified
upgrade-vagga.shbut do not know how to rebuild image so my changes get into virtualbox. I suppose that some changes into code will also be required as the hash of the new image will be different from the hash of the current image.