Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

Update README.md #714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gregorylearns
Copy link

@gregorylearns gregorylearns commented Mar 20, 2022

Add FossHub Link to download older Audacity versions to README.md
took me a while to find audacity 3.0.2 there

Signed-off-by: Gregory degeemon@gmail.com

Resolves: (direct link to the issue)

(short description of the changes and the motivation to make the changes)

Checklist
  • I have signed off my commits using -s or Signed-off-by* (See: Contributing § DCO)
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code*
  • I made sure the title of the PR reflects the core meaning of the issue you are solving*
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"*

* indicates required

Add FossHub Link to download older Audacity versions to README.md
took me a while to find audacity 3.0.2 there


Signed-off-by: Gregory<degeemon@gmail.com>
@n0toose
Copy link
Member

n0toose commented Mar 20, 2022

Hi, thanks for your contribution. You kind of missed a space in between of your name and your email, but I don't think this is a big deal.

README.md Outdated
@@ -45,7 +45,7 @@ Nevertheless, as a result of popular demand by the community, we decided to prov

The latest official version of Audacity that does not implement telemetry is `3.0.2`. Some Linux-based operating systems also ship Audacity with telemetry and networking features disabled by default.

Downloads for these versions can be found on the [Audacity website](https://www.audacityteam.org/download/). If you're looking for support regarding these versions, it may be worth consulting [Audacity's forum](https://forum.audacityteam.org/) or [Audacity's wiki](https://wiki.audacityteam.org/).
Downloads for these versions can be found on the [Audacity website](https://www.audacityteam.org/download/) or [FossHub Audacity Older Versions page](https://www.fosshub.com/Audacity-old.html). If you're looking for support regarding these versions, it may be worth consulting [Audacity's forum](https://forum.audacityteam.org/) or [Audacity's wiki](https://wiki.audacityteam.org/).
Copy link
Member

@n0toose n0toose Mar 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English sounds a little bit awkward here. Maybe referring to the page as "or the "Download Audacity older versions." page on Fosshub, "Fosshub's dedicated page for older Audacity versions", or something similar would be a bit better? :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. You kind of missed a space in between of your name and your email, but I don't think this is a big deal.

Thank you so much! This is my first time (or one of the first few times) contributing to open-source and my apologies if I missed some part of the contribution instructions.

I think Older versions of Audacity on Fosshub is better. Thank you again for the patience. However, I don't know how to edit my previous commit. Let me figure it out.

Add FossHub Link to download older Audacity versions to README.md
took me a while to find audacity 3.0.2 there

Signed-off-by: Gregory degeemon@gmail.com
@n0toose
Copy link
Member

n0toose commented Mar 20, 2022

Okay, now you're missing the < >'s :P

No worries! GitHub automatically removes them, so I understand why this is tricky. There's the --signoff parameter which makes this a whole lot easier when using the command line. You can also always use git log -p to check how previous commits look like.

@n0toose
Copy link
Member

n0toose commented Mar 20, 2022

I would say that the quotation marks in what I said are a bit important, because this title kind of "violates" the proper flow of the sentence and the fact that the reader is reading a title is not immediately recognizable. It's a small fix, I can also do it myself if you don't feel like it, just trying to show how I'd do this myself around here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants