Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selected list feature #39

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Added selected list feature #39

merged 2 commits into from
Apr 5, 2024

Conversation

IamHenryOkeke
Copy link
Collaborator

For an example of how to fill this template out, see this Pull Request.

Description

This code change render the current selected list on the UI

Related Issue

closes #14

Acceptance Criteria

Type of Changes

feature enhancement

Updates

Before

Screenshot from 2024-04-02 21-44-50

After

Screenshot from 2024-04-02 21-50-42

Testing Steps / QA Criteria

Do a git pull and switch branch to selectedListFeature branch. Run npm start in terminal to start development. Sign in if not signed. Select a list. You should now see the selected list in the UI precisely under the navbar.

Copy link

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit 4c6e08e):

https://tcl-72-smart-shopping-list--pr39-selectedlistfeature-bh5gxy1c.web.app

(expires Fri, 12 Apr 2024 09:02:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f7f2b0c98e4c5bce6be0f9b2cd44669f154caa67

Copy link
Collaborator

@ijayhub ijayhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mjzato
Copy link
Collaborator

mjzato commented Apr 4, 2024

I'm still having some visibility issues. My chome is not using dark mode so it´s black over dark blue

imagen

@IamHenryOkeke IamHenryOkeke merged commit 96433d8 into main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14. As a user, I want the app to look professional and welcoming
3 participants