Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling #45

Closed
wants to merge 3 commits into from
Closed

Styling #45

wants to merge 3 commits into from

Conversation

GrannyYetta
Copy link
Collaborator

@GrannyYetta GrannyYetta commented Sep 28, 2024

Description

The code now includes the base for the styling. Icons and fonts have been added and tailwind css has been initalized.

Related Issue

closes #36

Acceptance Criteria

  • Add the following icons:
    • One for Manage List
    • One for List
    • One for Home
    • One for About
    • One for the logo
  • Include the fonts to be used by the app
  • Initialize TailwindCSS installation
    • Create tailwind.config.js file in the project root directory.

Type of Changes

Layout.jsx

In the navigation, the words "Home", "List", "Manage List" and "About" were replaced with react icons.

Additionally, the tab no longer shows the react icon, but a shopping cart icon.

index.css

The Tailwind directives were added to the main CSS file, however commented out since the team still has to decide upon styles.

Tailwind, PostCSS and Autoprefixer packages were installed and initialized, so that tailwind.config.js and postcss.config.js files were added to the root folder. Also, the styles in the former were extended with the google fonts.

Updates

Before

Captura de pantalla 2024-09-28 a la(s) 20 02 38

Captura de pantalla 2024-09-28 a la(s) 20 02 54

Captura de pantalla 2024-09-28 a la(s) 20 04 28

After

Captura de pantalla 2024-09-28 a la(s) 20 09 01

Captura de pantalla 2024-09-28 a la(s) 20 11 18

Testing Steps / QA Criteria

  • npm start
  • Click on the navigation icons

Copy link

Visit the preview URL for this PR (updated for commit d61aad6):

https://tcl-78-smart-shopping-list--pr45-styling-5pk9pt4g.web.app

(expires Sat, 05 Oct 2024 18:13:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

@GrannyYetta GrannyYetta deleted the styling branch September 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant