This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
forked from richardkalehoff/reactnd-chirper-app
-
Notifications
You must be signed in to change notification settings - Fork 430
UI #4
Open
MarinEstrada
wants to merge
22
commits into
udacity:master
Choose a base branch
from
MarinEstrada:ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See README.md for details
Readme now has instructions to run locallly using docker, gitignore now ignores .swp files
In src/actions/shared.js fix getInitialData typo (missing 'i') In src/reducers/index.js remove 'function' from 'export default function' when functions called as default, do not need to surround with '{}' In src/reducers/users.js In src/reducers/tweets.js actions -> action on ln8
also fix typo it 'initial'in src/actions/shared.js
Initial setup of app and of initial data acquisition
render a list of tweet id's to render when page is fully loaded later these tweet ids will be exchanged for tweet containers
Added unnder src/components/NewTweet.js
Shows specified tweet, all its replies, and ability to reply to tweet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.