Retrieve Name servers displayed on multiple lines #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I had
When doing
whois
commands, I had some cases where the name servers were displayed on multiple lines.So I had either :
or :
The last way to display name servers did not handle by
golang-whois
. So, I decided to implement it.Proposed implementation
I choose to retrieve all the name servers with a regex. Then, the first line, which is
Name Servers :
, is skipped. The other lines are name servers and returned as a slice of string.Code to test
I used the following code to validate that my code does not insert any regression.
Link : https://goplay.space/#nWDdBdgvBf1