feat(backend): fix boolean environment cast

unitopia-de · Aug 12, 2024 · 8a4cda9 · 8a4cda9
1 parent fc34841
commit 8a4cda9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/backend/src/core/environment/environment.spec.ts b/backend/src/core/environment/environment.spec.ts
@@ -74,6 +74,22 @@ describe('Environment', () => {
     expect(env.telnetTLS).toBe(true);
   });
 
+  it('should handle TRUE as boolean values for TLS configuration', async () => {
+    process.env.TELNET_HOST = 'localhost';
+
+    process.env.TELNET_PORT = '3000';
+
+    process.env.SOCKET_ROOT = '/socket.io';
+
+    process.env.CHARSET = 'utf8';
+
+    process.env.TELNET_TLS = 'TRUE';
+
+    const env = await getFreshEnvironmentInstance();
+
+    expect(env.telnetTLS).toBe(true);
+  });
+
   it('should handle missing TLS configuration gracefully', async () => {
     process.env.TELNET_HOST = 'localhost';
 

diff --git a/backend/src/core/environment/environment.ts b/backend/src/core/environment/environment.ts
@@ -38,7 +38,11 @@ export class Environment implements IEnvironment {
     this.telnetPort = Number(getEnvironmentVariable('TELNET_PORT'));
 
     this.telnetTLS =
-      getEnvironmentVariable('TELNET_TLS', false, 'false') === 'true';
+      getEnvironmentVariable(
+        'TELNET_TLS',
+        false,
+        'false',
+      )?.toLocaleLowerCase() === 'true';
 
     this.socketRoot = String(getEnvironmentVariable('SOCKET_ROOT'));