Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): added NAWS support #123

Merged
merged 2 commits into from
Nov 3, 2024
Merged

feat(backend): added NAWS support #123

merged 2 commits into from
Nov 3, 2024

Conversation

mystiker
Copy link
Collaborator

@mystiker mystiker commented Nov 3, 2024 •
edited
Loading

This PR adds support for the Telnet Option NAWS.

In detail:

  • we accept an incoming DO with WILL
  • we refuse an incoming WILL with DONT since our responsive client is not designed to handle various "display" sizes
  • we use a static 80x25 dimension for the subnogitiation

Also included:

  • refactored some functions to pure ones
  • refactored some names for types
  • added a readme for the whole telnet feature

Fixes #108

@mystiker
feat(backend): added NAWS support
27e3f42 
- use a static 80x25 subnogitiation
- refactored some funktions to pure ones
- refactored some names for types
@mystiker
feat(backend): changed default values for NAWS
09df61f
myonara
myonara approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@myonara myonara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok an bespoken

@myonara myonara merged commit e44ab63 into develop Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myonara myonara myonara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Telnet NAWS Option
2 participants
@mystiker @myonara