Update to full multisource and to a slimmed down common #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Sep 27, 2024
mbaldessari
commented
- Replace tabs with spaces and add some missing env vars that could be passed
- Also push any changes to operator-install to its own repo
- Update CRD from operator v0.0.55
- Fix chart name in pattern-install branch+split wf
- Tweak readme
- Use $group.name in clusterset metadata
- Expose originURL as helm value
- Update tests after common rebase
- Release clustergroup v0.8.13
- Release acm v0.1.2
- Drop schema required under the Main section
- Release clustergroup v0.8.14
- Drop all the helm charts
- README fixes
- Drop the operator-install folder (pattern-install chart)
- Start using the OCI chart in lieu of operator-install
- Drop the chart splitting workflows
- Drop the test folder
- Drop the json schema checking job
- Add a README note on the main branch
- Add a check to see if multisource for clustergroup is enabled
- Move the common slim + multisource test into Makefile
- Drop last bit of operator-install and the common symlink
- Drop reference-output.yaml as it makes little sense in the slimmed common
- Remove ansible code in favor of external collection
- Make adjustments for ansible code moving into separate collection repo
- Add a note about the changes in common
- Remove assorted detritus
- We don't have charts to test anymore
- Drop lint.sh and its target in Makefile
- Drop test.sh and its target in Makefile and also kubeconform
- Move to slimmed common
Replace tabs with spaces and add some missing env vars that could be passed
Since at the time the folder was named operator-install and the chart pattern-install, let's push it out to the `pattern-install-chart` repo which is a bit clearer.
Also push any changes to operator-install to its own repo
Update CRD from operator v0.0.55
Fix chart name in pattern-install branch+split wf
Use $group.name in clusterset metadata
This is needed, this way when this variable is set we can actually detect that an in-cluster gitea instance has been set up.
Release clustergroup v0.8.13
Release acm chart 0.1.2
The "main" subsection of helm values is only used for kickstarting a pattern. It is entirely possible to only set one value and then set the other variables through other means (editing CRs e.g.). There is no point on blocking this.
Drop schema required under the Main section
All the charts that can be used via an OCI registry or via a helm repo are dropped in this change
We do not push any changes from common to the chart because they do not exist in common any longer
It used to contain expected tests for the different charts, but those have moved away, so let's start dropping these for now.
It only makes sense in the presence of helm charts. We should prolly move it to each chart repo.
Add a README note on the main branch
Slim down common
Without this in your values-global.yaml files, the deployment with a
slimmed down common would fail as follows:
- lastTransitionTime: "2024-09-13T18:30:19Z"
message: 'Failed to load target state: failed to generate manifest for source
1 of 1: rpc error: code = Unknown desc = Manifest generation error (cached):
common/clustergroup: app path does not exist'
Add a check to see if multisource for clustergroup is enabled
This way yq is not required on the host. Tested as follows:
* No value set (assumes default is false)
❯ cat values-global.yaml
---
global:
pattern: multicloud-gitops
options:
useCSV: false
syncPolicy: Automatic
installPlanApproval: Automatic
main:
clusterGroupName: hub
# multiSourceConfig:
# enabled: true
❯ ./pattern.sh make validate-prereq
make -f common/Makefile validate-prereq
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
You must set ".main.multiSourceConfig.enabled: true" in your 'values-global.yaml' file
because your common subfolder is the slimmed down version with no helm charts in it
make[1]: *** [common/Makefile:161: validate-prereq] Error 1
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
make: *** [Makefile:12: validate-prereq] Error 2
* Value set to false
❯ cat values-global.yaml
---
global:
pattern: multicloud-gitops
options:
useCSV: false
syncPolicy: Automatic
installPlanApproval: Automatic
main:
clusterGroupName: hub
multiSourceConfig:
enabled: false
❯ ./pattern.sh make validate-prereq
make -f common/Makefile validate-prereq
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
You must set ".main.multiSourceConfig.enabled: true" in your 'values-global.yaml' file
because your common subfolder is the slimmed down version with no helm charts in it
make[1]: *** [common/Makefile:161: validate-prereq] Error 1
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
make: *** [Makefile:12: validate-prereq] Error 2
* Value set to true
❯ cat values-global.yaml
---
global:
pattern: multicloud-gitops
options:
useCSV: false
syncPolicy: Automatic
installPlanApproval: Automatic
main:
clusterGroupName: hub
multiSourceConfig:
enabled: true
❯ ./pattern.sh make validate-prereq
make -f common/Makefile validate-prereq
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Move the common slim + multisource test into Makefile
Drop last bit of operator-install and the common symlink
Drop reference-output.yaml as it makes little sense in the slimmed common
Factor out ansible into separate collection repo
Add a note about the changes in common
Remove assorted detritus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.