Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update references to org public profile -> page #2330

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 22, 2025

Resolves #2329

Changes

  • Renames public URL prefix to explore
  • Updates org settings sections
  • Removes or renames references to "org profile"

Manual testing

  1. Log in as org admin
  2. Go to org settings
  3. Regression test org settings, verifying that public page still works as expected

Screenshots

Page Image/video
Org Settings Screenshot 2025-01-21 at 8 52 10 PM
User guide Screenshot 2025-01-21 at 9 07 08 PM

@SuaYoo SuaYoo marked this pull request as ready for review January 22, 2025 02:28
@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 22, 2025

Putting back into draft to look into feasibility of combining the sections, per Discord thread

@SuaYoo SuaYoo marked this pull request as draft January 22, 2025 03:26
@SuaYoo SuaYoo marked this pull request as ready for review January 22, 2025 05:08
@Shrinks99
Copy link
Member

Shrinks99 commented Jan 22, 2025

Mostly looks good to me! Any big reason for swapping the control to the other side of the window? Seems like we could use the same column layout with the help text on the right? Labels all look good!

@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 22, 2025

Any big reason for swapping the control to the other side of the window?

I copied the pattern for the account settings toggle, which updates immediately on toggle (rather than a save button)--but don't feel strongly if we want to add back the save button?

@ikreymer ikreymer added this to the Public Collections milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update public view URL prefix
3 participants