Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors and logging improvements #10

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 12, 2024

make common::Error a proper error

This allows using it in eyre and chaining it with other errors.

rust: improve logging and error formatting

Use the `tracing` crate to show logs, and honor `RUST_LOG` env var to
change log-level. Make some of the debugging statements debug! calls,
and fields rather than interpolated in the message.

Use the `.context(&'static str')?` pattern to annotate some info about
where things go wrong.`

image

flokli added 2 commits July 12, 2024 12:33
This allows using it in eyre and chaining it with other errors.
Use the `tracing` crate to show logs, and honor `RUST_LOG` env var to
change log-level. Make some of the debugging statements debug! calls,
and fields rather than interpolated in the message.

Use the `.context(&'static str')?` pattern to annotate some info about
where things go wrong.`
@VanuPhantom VanuPhantom added the enhancement New feature or request label Jul 12, 2024
@VanuPhantom VanuPhantom merged commit 7d583ee into wipbar:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants