Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix(backup-repo): do not pass files to debug logs after validating metadata [WPB-15317] #18583

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Jan 13, 2025

TaskWPB-15317 [Web] Cannot restore prod backup to current edge webapp

Description

Electron appears to be running into heap size issues because of JSON.stringify of the entire passed files with this debug logs.

We want to pinpoint the issue by removing the passed files from the logs

Note

This file has been refactored in the dev branch, this is a specific fix for the release candidate, and will need to be reverted before merging back dev on next release

see the PR on dev here #18580

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.58%. Comparing base (8288f2c) to head (e3bd377).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18583      +/-   ##
==========================================
- Coverage   46.60%   46.58%   -0.02%     
==========================================
  Files         835      835              
  Lines       26076    26076              
  Branches     5917     5917              
==========================================
- Hits        12153    12148       -5     
- Misses      12410    12413       +3     
- Partials     1513     1515       +2     

@V-Gira V-Gira merged commit 5f43c3a into master Jan 13, 2025
19 checks passed
@V-Gira V-Gira deleted the v/fix-restore-backup-issue branch January 13, 2025 12:18
@paulwire paulwire added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants