Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add vertical spacing to show more button for replies [WPB-11935] #18584

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: add vertical spacing to show more button for replies [WPB-11935] #18584

merged 1 commit into from
Jan 13, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Jan 13, 2025 •
edited by github-actions bot
Loading

BugWPB-11935 [Web] Fix "Show more" button spacing

Description

Fixes the spacing issue for the "Show More" button when focused with keyboard.

Screenshots/Screencast (for UI changes)

Before

image-20241030-092743

After

Screenshot 2025-01-13 at 13 20 26

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@waseemansar waseemansar requested review from otto-the-bot and a team as code owners January 13, 2025 12:40
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@waseemansar waseemansar merged commit 105b1e2 into dev Jan 13, 2025
15 of 16 checks passed
@waseemansar waseemansar deleted the fix/show-more-button-spacing-WPB-11935 branch January 13, 2025 16:22
@paulwire paulwire added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V-Gira V-Gira V-Gira approved these changes

@olafsulich olafsulich olafsulich approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@waseemansar @CLAassistant @olafsulich @V-Gira @otto-the-bot @paulwire