fix: handle multiple tsconfig extends
for resolving GraphQLSP plugin entry
#386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given the following
tsconfig.json
setup:I encounter the following error:
Could not find a valid GraphQLSP plugin entry in: tsconfig.json
The code in this PR fixes the issue for me, but there aren't unit tests specifically for this area of code so not sure of any adverse effects.
Set of changes
The change was pretty straightforward in just modifying
return load(tsconfigPath)
to bereturn await load(tsconfigPath)
so that exceptions thrown when trying to load nested tsconfig "extends" elements are caught (and swallowed) by the intendedcatch(_error)
statements.