Fix zone issue #38
Merged
Fix zone issue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the zone filter raised in #37. Originally, this was built to only alert on new events from Frigate. However, Frigate will send updated event notifications to MQTT upon certain things, like the detected object moving to a different zone.
So with the zone filter built as it was originally, the app would only send an event if there was a new event that contained a zone. If an event started with no zone info, and was updated later, no notification would be sent. App code adjusted to account for event updates, and compare zone details. New alerts will only be sent if the object enters a new zone & also that zone is on the allowed notification list.
Also added the ability to provide custom date / time formats to be used in the notifications. And cleaned up some logs to ensure that all event-related logs should have the event ID attached.