Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4472 feat(portal,graphql): query consumer claim details #957

Merged

Conversation

jonathanprozzi
Copy link
Member

Affected Packages

Apps

  • data populator
  • portal
  • template

Packages

  • 1ui
  • api
  • graphql
  • protocol
  • sdk

Tools

  • tools

Overview

  • Converts the Claim Details pages (index and id) to use GraphQL. Adds the necessary queries to get the data as well as check if the Claim is part of a List and also to pull the For/Against positions. Creates a new version of the DetailInfoCard component to not break the Readonly route build until we fully migrate and then we can remove
  • Handling the positions was the biggest change from the previous implementation. Previously, all positions came through in a single list with a for and against direction as a property. This isn't the case now, so we needed to combine the vault and counterVault positions together. This works, but there are definitely performance improvements, especially since we should likely be doing the tab filtering client side instead of a refresh. There's room for us to continue to improve in the future.
  • Also, the search/sort/pagination will be wired up to the UI component in a future PR, but the query supports it!
  • @Vitalsine85 -- The staking modals will need to be updated as part of the sweep you do. That should cover all the bases here!

Screen Captures

claim-details-graphql

Declaration

  • I hereby declare that I have abided by the rules and regulations as outlined in the CONTRIBUTING.md

Copy link

linear bot commented Nov 27, 2024

@jonathanprozzi jonathanprozzi force-pushed the eng-4472-query-consumer-claim-details branch from 73f2046 to f50499e Compare November 27, 2024 18:20
@jonathanprozzi jonathanprozzi merged commit 702d93f into feature/graphql-migration Nov 27, 2024
2 checks passed
@github-actions github-actions bot added the feat Feature label Nov 27, 2024
@jonathanprozzi jonathanprozzi deleted the eng-4472-query-consumer-claim-details branch November 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants