Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fund l2 accounts and deploy deterministic deployment proxy #316

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

minhd-vu
Copy link
Contributor

@minhd-vu minhd-vu commented Oct 16, 2024

Description

  • Funds accounts on l2
  • Adds DEFAULT_L2_ARGS to determine how many and how much to fund
  • Deploys deterministic deployment proxy to both L1 and L2

References (if applicable)

@@ -17,7 +17,7 @@
# WARNING (SC1091): (Sourced) file not included in mock.
# hadolint ignore=DL3008,DL3013,DL4006,SC1091
RUN apt-get update \
&& apt-get install --yes --no-install-recommends curl git jq pipx \
&& apt-get install --yes --no-install-recommends curl git jq pipx nodejs npm \

Check notice

Code scanning / SonarCloud

Arguments in long RUN instructions should be sorted

<!--SONAR_ISSUE_KEY:AZK1eCyy117yESGJTC9d-->Sort these package names alphanumerically. <p>See more on <a href="https://sonarcloud.io/project/issues?id=0xPolygon_kurtosis-cdk&issues=AZK1eCyy117yESGJTC9d&open=AZK1eCyy117yESGJTC9d&pullRequest=316">SonarCloud</a></p>
@minhd-vu minhd-vu changed the title feat: fund l2 accounts feat: fund l2 accounts and deploy deterministic deployment proxy Oct 23, 2024
@minhd-vu minhd-vu marked this pull request as ready for review October 24, 2024 17:50
input_parser.star Outdated Show resolved Hide resolved
@@ -33,7 +35,7 @@ DEFAULT_IMAGES = {
"zkevm_bridge_proxy_image": "haproxy:3.0-bookworm", # https://hub.docker.com/_/haproxy/tags
"zkevm_bridge_service_image": "hermeznetwork/zkevm-bridge-service:v0.6.0-RC1", # https://hub.docker.com/r/hermeznetwork/zkevm-bridge-service/tags
"zkevm_bridge_ui_image": "leovct/zkevm-bridge-ui:multi-network-2", # https://hub.docker.com/r/leovct/zkevm-bridge-ui/tags
"zkevm_contracts_image": "leovct/zkevm-contracts:v8.0.0-rc.4-fork.12", # https://hub.docker.com/repository/docker/leovct/zkevm-contracts/tags
"zkevm_contracts_image": "minhdvu/zkevm-contracts:v8.0.0-rc.4-fork.12", # https://hub.docker.com/repository/docker/leovct/zkevm-contracts/tags
Copy link
Contributor Author

@minhd-vu minhd-vu Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leovct I'll change this to leovct whenever you finish your script. Looks like I'll need to update the other images too since CI is failing, since they're built on older go version.

command=[
"/bin/sh",
"-c",
"export l2_rpc_url={0} && chmod +x {1} && {1}".format(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praetoriansentry tried out the upload_files but that produces an artifact, which I think needs to be added to the service when calling add_service. I don't think it would fit in this case.

Copy link

sonarcloud bot commented Oct 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants