Include additional information to output batches MDBX browser tool #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
fix/output-batches-by-number-mdbx-db-tool
branch
from
88dd4fa to
3851b84
Compare
revitteth
previously approved these changes
Aug 29, 2024
Stefan-Ethernal
force-pushed
the
fix/output-batches-by-number-mdbx-db-tool
branch
from
e704269 to
cb1e789
Compare
Stefan-Ethernal
force-pushed
the
fix/output-batches-by-number-mdbx-db-tool
branch
from
cb1e789 to
586c8cd
Compare
Stefan-Ethernal
force-pushed
the
fix/output-batches-by-number-mdbx-db-tool
branch
from
586c8cd to
862ae6b
Compare
|
revitteth
approved these changes
Aug 30, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 20, 2024
…1047) * Populate additional details in the batch (WIP) * Use the const for the fork id identifier * GetBatchDataByNumbers add error handling and remove transactions collection * Populate additional fields for the batches * Implement output-batch-affiliation command * Fix tests * Fix DbDataRetriever UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns (as much as possible, since it is an offline tool) output of
output-batchesCLI command in the MDBX DB browser tool with thezkevm_getBatchByNumber.It also implements new command called
output-batch-affiliation, that prints the batch numbers, for the provided block numbers.