Tweak: RollupID #1053
Merged
Tweak: RollupID #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
revitteth
commented
Aug 28, 2024
•
revitteth
commented
- print rollupid on startup
- ensure rollupid is always used from config
- discard logs where pre-etrog and rollupid > 1 (pre-etrog only rollupid was 1)
revitteth
changed the title
V-Staykov
previously approved these changes
Aug 28, 2024
revitteth
commented
Aug 28, 2024
revitteth
force-pushed
the
fix/rollupid
branch
2 times, most recently
from
5828743 to
7cb30b0
Compare
revitteth
force-pushed
the
fix/rollupid
branch
from
7cb30b0 to
5e898e9
Compare
V-Staykov
previously approved these changes
Aug 30, 2024
# Conflicts: # zk/stages/stage_l1syncer.go
|
mandrigin
approved these changes
Sep 4, 2024
hexoscott
added a commit
that referenced
this pull request
Sep 4, 2024
* tweak: print rollupid, and use from config in zkevm_api * tweak(l1sync): disgard logs for wrong rollupid * tweak(l1sync): discard pre-etrog verifications for rollupid > 1 * fix(l1syncer): sequences post etrog * rejig of batch closing logic in the sequencer (#1095) * catch post etrog sequence events --------- Co-authored-by: hexoscott <70711990+hexoscott@users.noreply.github.com> Co-authored-by: Scott Fairclough <scott@hexosoft.co.uk>
Damantino
pushed a commit
to Damantino/cdk-erigon
that referenced
this pull request
Sep 4, 2024
* tweak: print rollupid, and use from config in zkevm_api * tweak(l1sync): disgard logs for wrong rollupid * tweak(l1sync): discard pre-etrog verifications for rollupid > 1 * fix(l1syncer): sequences post etrog * rejig of batch closing logic in the sequencer (0xPolygonHermez#1095) * catch post etrog sequence events --------- Co-authored-by: hexoscott <70711990+hexoscott@users.noreply.github.com> Co-authored-by: Scott Fairclough <scott@hexosoft.co.uk>
hexoscott
added a commit
that referenced
this pull request
Sep 19, 2024
* tweak: print rollupid, and use from config in zkevm_api * tweak(l1sync): disgard logs for wrong rollupid * tweak(l1sync): discard pre-etrog verifications for rollupid > 1 * fix(l1syncer): sequences post etrog * rejig of batch closing logic in the sequencer (#1095) * catch post etrog sequence events --------- Co-authored-by: hexoscott <70711990+hexoscott@users.noreply.github.com> Co-authored-by: Scott Fairclough <scott@hexosoft.co.uk>
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Sep 20, 2024
* tweak: print rollupid, and use from config in zkevm_api * tweak(l1sync): disgard logs for wrong rollupid * tweak(l1sync): discard pre-etrog verifications for rollupid > 1 * fix(l1syncer): sequences post etrog * rejig of batch closing logic in the sequencer (#1095) * catch post etrog sequence events --------- Co-authored-by: hexoscott <70711990+hexoscott@users.noreply.github.com> Co-authored-by: Scott Fairclough <scott@hexosoft.co.uk>
hexoscott
added a commit
that referenced
this pull request
Sep 25, 2024
* tweak: print rollupid, and use from config in zkevm_api * tweak(l1sync): disgard logs for wrong rollupid * tweak(l1sync): discard pre-etrog verifications for rollupid > 1 * fix(l1syncer): sequences post etrog * rejig of batch closing logic in the sequencer (#1095) * catch post etrog sequence events --------- Co-authored-by: hexoscott <70711990+hexoscott@users.noreply.github.com> Co-authored-by: Scott Fairclough <scott@hexosoft.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.