get batch data by number api #1090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revitteth
approved these changes
Sep 4, 2024
|
Looks like this breaks kurtosis - please investigate! |
mandrigin
requested changes
Sep 4, 2024
cmd/rpcdaemon/commands/zkevm_api.go
Outdated
| @@ -320,6 +320,16 @@ func (api *ZkEvmAPIImpl) GetBatchDataByNumbers(ctx context.Context, batchNumbers | |||
| continue | |||
| } | |||
|
|
|||
| // try to find the BatchData in db to avoid calculate it when it is possible | |||
| batchData, err := hermezDb.GetL1BatchData(batchNumber.Uint64()) | |||
There was a problem hiding this comment.
We probably should extract the rest as “GenerateL1BatchData” to have the whole structure more clear. Otherwise it’s okay.
|
This is already done, closing. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a modification in GetBatchDataByNumbers endpoint to avoid calculate batchData when it is stored in db