Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract zkevm api fulltx function #1246

Merged
merged 1 commit into from
Sep 30, 2024
Merged

refactor: extract zkevm api fulltx function #1246

merged 1 commit into from
Sep 30, 2024

Conversation

V-Staykov
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
@V-Staykov V-Staykov enabled auto-merge (squash) September 30, 2024 09:38
hexoscott
hexoscott approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@hexoscott hexoscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change for readability, but is there any way we could return a type over the interface{}? Could it be a map[string]string for example?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@V-Staykov V-Staykov merged commit 8d69064 into zkevm Sep 30, 2024
11 checks passed
@V-Staykov V-Staykov deleted the refactor-zkevm-branch-2 branch September 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexoscott hexoscott hexoscott approved these changes

@kstoykov kstoykov kstoykov approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-Staykov @kstoykov @hexoscott