Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1265 sequencer reject transactions with gas higher than the cap. #1272

Closed
wants to merge 1 commit into from
Closed

1265 sequencer reject transactions with gas higher than the cap. #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions zk/txpool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ const (
DiscardByLimbo DiscardReason = 27
SmartContractDeploymentDisabled DiscardReason = 28 // to == null not allowed, config set to block smart contract deployment
GasLimitTooHigh DiscardReason = 29 // gas limit is too high
GasHigherThanCap DiscardReason = 30 // gas is higher than the cap of limit
)

func (r DiscardReason) String() string {
Expand Down Expand Up @@ -209,6 +210,8 @@ func (r DiscardReason) String() string {
return "limbo error"
case SmartContractDeploymentDisabled:
return "smart contract deployment disabled"
case GasHigherThanCap:
return fmt.Sprintf("gas higher than cap, Max: %d", transactionGasLimit)
case GasLimitTooHigh:
return fmt.Sprintf("gas limit too high. Max: %d", transactionGasLimit)
default:
Expand Down Expand Up @@ -740,12 +743,21 @@ func (p *TxPool) validateTx(txn *types.TxSlot, isLocal bool, stateCache kvcache.
}
return reason
}

if gas > transactionGasLimit {
if txn.Traced {
log.Info(fmt.Sprintf("TX TRACING: validateTx intrinsic gas > transactionGasLimit idHash=%x gas=%d, cap=%d", txn.IDHash, gas, transactionGasLimit))
}
return GasHigherThanCap
}

if gas > txn.Gas {
if txn.Traced {
log.Info(fmt.Sprintf("TX TRACING: validateTx intrinsic gas > txn.gas idHash=%x gas=%d, txn.gas=%d", txn.IDHash, gas, txn.Gas))
}
return IntrinsicGas
}

if txn.Gas > transactionGasLimit {
if txn.Traced {
log.Info(fmt.Sprintf("TX TRACING: validateTx gas limit too high idHash=%x gas=%d, limit=%d", txn.IDHash, txn.Gas, transactionGasLimit))
Expand Down
Loading