1298 acl access control list augmentation #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afa7789
force-pushed
the
1298-acl-access-control-list-augmentation
branch
from
72830bd to
49dc0ca
Compare
|
hexoscott
requested changes
Oct 14, 2024
|
Hi @afa7789 - are we considering this good to review again? Did adding the log level stuff back in help with the v3 logging library problem you were seeing? |
afa7789
force-pushed
the
1298-acl-access-control-list-augmentation
branch
from
8be071a to
a422207
Compare
revitteth
previously approved these changes
Oct 18, 2024
revitteth
force-pushed
the
1298-acl-access-control-list-augmentation
branch
from
a422207 to
5ca4db5
Compare
hexoscott
previously approved these changes
Oct 18, 2024
afa7789
force-pushed
the
1298-acl-access-control-list-augmentation
branch
from
5ca4db5 to
5c7b977
Compare
hexoscott
approved these changes
Oct 18, 2024
also function can be reused by other parts of the code.
added call to the function for it to log in parts of the code, this will be reviewed.
creating functions to interact with table as binary, and other helper functions that we may need.
…r logging imports changing log structure, cause it's failing. changed the function at txpool so I can get the string to put in the log at the CLI level since it doesn't log too.
fixing update method which was exiting on panic, also improved the function of insert to be able to insert an array improving code quality
…ly is the config updater now)
…n debugging// looking for it. not an issue for usage, only a improvement.
it could either remove or add the policy at the same time someone else was checking for another scenario to fix I added the adding flow, to updating/changing tx before making the update with the same asserting checks for correct adding.
afa7789
force-pushed
the
1298-acl-access-control-list-augmentation
branch
from
c1506b6 to
9e56240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new features to ACL to make easier to use.