Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change RPCs to use latest finished block #1305

Merged
merged 14 commits into from
Oct 21, 2024

Conversation

MorettiGeorgiev
Copy link
Collaborator

@MorettiGeorgiev MorettiGeorgiev commented Oct 10, 2024

Fixes: #701

  • Change RPCs to use latest finished block instead of the latest executed
  • Didn't make changes to GetBlockByNumber_deprecated because of the _deprecated suffix

@cla-bot cla-bot bot added the cla-signed label Oct 10, 2024
@cffls
Copy link

cffls commented Oct 10, 2024

Looks like this will break the chain with Cancun enabled: https://github.com/0xPolygonHermez/cdk-erigon/actions/runs/11275320161/job/31360641763?pr=1305

@MorettiGeorgiev MorettiGeorgiev merged commit 9257579 into zkevm Oct 21, 2024
13 checks passed
@MorettiGeorgiev MorettiGeorgiev deleted the add-rpcs-return-finished-block branch October 21, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RPC] - some calls return inconsistent data
5 participants