Remove SMT logic for Zero Prover #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachit77
changed the title
cffls
reviewed
Oct 29, 2024
|
Looks good to me overall. Let's test this in kurtosis and make sure the state root of L2 blocks remains the same when the blocks are empty. |
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 4, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 5, 2024
|
Used this branch and created an L2 with normalcy enabled using kurtosis, but the state roots are different between each block. Maybe there are still something missing. |
cffls
reviewed
Nov 5, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 6, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 6, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 6, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Nov 6, 2024
cffls
approved these changes
Nov 7, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary logic for Pre state execution and SMT which are not required by zero prover