Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier fixes #205

Merged
merged 12 commits into from
Mar 21, 2024
Merged

Verifier fixes #205

merged 12 commits into from
Mar 21, 2024

Conversation

hexoscott
Copy link
Collaborator

No description provided.

@kstoykov
Copy link
Collaborator

kstoykov commented Mar 19, 2024

Could someone else try whether tx-repeater works alongside a sequencer compiled from this branch, because it does not work on my local setup. Tx-repeater itself it fine but the sequencer goes into infinite loop because it is unable to verify batches.

P.S. I'm trying to repeat mainnet transactions.

@hexoscott
Copy link
Collaborator Author

Looks like this is an issue with the stream itself, I get timeouts locally trying to sync from it. Will take a look

@kstoykov
Copy link
Collaborator

kstoykov commented Mar 19, 2024

Looks like this is an issue with the stream itself, I get timeouts locally trying to sync from it. Will take a look

I got either "erigon state root mismatch" if a tx is a funding (from our faucet wallet) or "error in response: EXECUTOR_ERROR_DB_KEY_NOT_FOUND" if a tx is a regular repeated mainnet tx.

@mandrigin
Copy link
Collaborator

@kstoykov what if you disable the upstream executor?

@mandrigin mandrigin marked this pull request as draft March 19, 2024 17:26
@mandrigin
Copy link
Collaborator

@hexoscott I drafted that until the known issue with erigon-to-erigon is fixed

@kstoykov
Copy link
Collaborator

@kstoykov what if you disable the upstream executor?

Tx-repeater works as expected by disabling the remote executor.

@hexoscott
Copy link
Collaborator Author

I think there is a separate task here to make the datastream stage also async like the verifier which will solve the stream problems. At the moment the stream is only populating when you get block N+1 because we're waiting on verifications. Going to make this a proper PR now that erigon-to-erigon sync is working again.

@hexoscott hexoscott marked this pull request as ready for review March 20, 2024 08:39
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@revitteth revitteth merged commit 9f6366f into zkevm Mar 21, 2024
4 checks passed
@revitteth revitteth deleted the verifier-fixes branch March 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants