Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/memory align with proxy #173

Open
wants to merge 56 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
16ac673
first commit on memory_checkpoint3
xavi-pinsach Nov 5, 2024
36573d9
fix Arc<ZiskRom>
xavi-pinsach Nov 5, 2024
9d4be19
wip
xavi-pinsach Nov 5, 2024
c53b500
First commit
hecmas Nov 5, 2024
0f4441f
First version of mem_align executor done
hecmas Nov 5, 2024
3ccfde2
wip
xavi-pinsach Nov 6, 2024
c7a6cf9
Working in the new version
hecmas Nov 6, 2024
71ca095
wip
xavi-pinsach Nov 6, 2024
668c37d
wip
xavi-pinsach Nov 6, 2024
59b5376
minor changes
hecmas Nov 6, 2024
855b382
Merge branch 'mem-integration' into feature/memory-align
hecmas Nov 6, 2024
b386952
Working
hecmas Nov 6, 2024
6094b79
wip
xavi-pinsach Nov 7, 2024
5551def
Fixing bugs
hecmas Nov 7, 2024
1f7786e
mem_proxy to little endian
xavi-pinsach Nov 7, 2024
89a59ad
Fix mem bugs
hecmas Nov 7, 2024
601e524
Merge remote-tracking branch 'origin/develop' into mem-integration
xavi-pinsach Nov 7, 2024
968a539
Fix mem bugs
hecmas Nov 7, 2024
96131a8
remove println
xavi-pinsach Nov 7, 2024
7ad568f
Minor fixes
hecmas Nov 7, 2024
3cdb3ac
Merge branch 'mem-integration' into feature/memory-align
hecmas Nov 7, 2024
5380f5b
wip
hecmas Nov 7, 2024
f77db6b
wip
hecmas Nov 8, 2024
0036a50
Mem align compiling
hecmas Nov 8, 2024
d67b280
fixes
hecmas Nov 8, 2024
451cdfb
WIP mem proxy, rebase
zkronos73 Nov 8, 2024
ad7381e
rebase
zkronos73 Nov 8, 2024
257fe75
Range check done
hecmas Nov 8, 2024
125b205
minor bugs,logs on memory proxy
zkronos73 Nov 9, 2024
54c2fb7
Merge branch 'feature/memory-align' into feature/mem-align-proxy
hecmas Nov 9, 2024
bb1207c
Merge pull request #160 from 0xPolygonHermez/feature/mem-align-proxy
hecmas Nov 9, 2024
00fd718
filter some address to test
zkronos73 Nov 9, 2024
f6fbc3d
wip
hecmas Nov 9, 2024
51416cf
Merge branch 'feature/memory-align' into feature/mem-align-proxy
zkronos73 Nov 9, 2024
0c0d19a
Cleaning up
hecmas Nov 10, 2024
66d20db
Fix errors
hecmas Nov 10, 2024
2b511ec
mem align working
hecmas Nov 11, 2024
c5a8683
CArgo fmt
hecmas Nov 20, 2024
99f4b8c
WIP memory proxy
zkronos73 Nov 21, 2024
ab916e0
merge changes of mem_align
zkronos73 Nov 21, 2024
e46ebf2
merge develop on branch
zkronos73 Nov 21, 2024
9d8e75c
WIP memory state machhines
zkronos73 Nov 21, 2024
5819463
WIP memory proxy
zkronos73 Nov 21, 2024
632d7cd
Mem rom fully working
hecmas Nov 22, 2024
e92abdd
Mem align fully working
hecmas Nov 22, 2024
4593a0d
WIP mem proxy
zkronos73 Nov 22, 2024
5aeb580
merge changes of feature/memory-align to feature/memory-align-with-proxy
zkronos73 Nov 22, 2024
abcb73c
Cleaning the mem align
hecmas Nov 22, 2024
cec3d41
Removing hashmaps and cleaning up stuff a little bit
hecmas Nov 22, 2024
5b37bc2
WIP mem - mem_align integration
zkronos73 Nov 22, 2024
8f61207
WIP merge changes from feature/memory-align to feature/memory-align-w…
zkronos73 Nov 22, 2024
e0ebd21
fix bugs with memory
zkronos73 Nov 24, 2024
84be677
Fixing typos
hecmas Nov 25, 2024
4960e93
Merge pull request #174 from 0xPolygonHermez/fix/mem-align
hecmas Nov 25, 2024
42287a2
Merge branch 'develop' into feature/memory-align-with-proxy
zkronos73 Nov 25, 2024
5ef0915
Mem align and mem fixes (#175)
hecmas Nov 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,19 @@ opt-level = 3
opt-level = 3

[workspace.dependencies]
proofman-common = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
proofman-macros = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
proofman-util = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
proofman = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
pil-std-lib = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
stark = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# proofman-common = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# proofman-macros = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# proofman-util = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# proofman = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# pil-std-lib = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# stark = { git = "https://github.com/0xPolygonHermez/pil2-proofman.git", rev = "0.0.10" }
# Local development
# proofman-common = { path = "../pil2-proofman/common" }
# proofman-macros = { path = "../pil2-proofman/macros" }
# proofman-util = { path = "../pil2-proofman/util" }
# proofman = { path = "../pil2-proofman/proofman" }
# pil-std-lib = { path = "../pil2-proofman/pil2-components/lib/std/rs" }
# stark = { path = "../pil2-proofman/provers/stark" }
proofman-common = { path = "../pil2-proofman/common" }
proofman-macros = { path = "../pil2-proofman/macros" }
proofman-util = { path = "../pil2-proofman/util" }
proofman = { path = "../pil2-proofman/proofman" }
pil-std-lib = { path = "../pil2-proofman/pil2-components/lib/std/rs" }
stark = { path = "../pil2-proofman/provers/stark" }

p3-field = { git = "https://github.com/Plonky3/Plonky3.git", rev = "c3d754ef77b9fce585b46b972af751fe6e7a9803" }
log = "0.4"
Expand Down
25 changes: 21 additions & 4 deletions core/src/zisk_required_operation.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::collections::HashMap;
use std::{collections::HashMap, fmt};

#[derive(Clone)]
pub struct ZiskRequiredOperation {
Expand All @@ -10,13 +10,30 @@ pub struct ZiskRequiredOperation {

#[derive(Clone)]
pub struct ZiskRequiredMemory {
pub step: u64,
pub address: u32,
pub is_write: bool,
pub address: u64,
pub width: u64,
pub width: u8,
pub step_offset: u8,
pub step: u64,
pub value: u64,
}

impl fmt::Debug for ZiskRequiredMemory {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
let label = if self.is_write { "WR" } else { "RD" };
write!(
f,
"{0} addr:{1:#08X}({1}) offset:{5} with:{2} value:{3:#016X}({3}) step:{4}",
label,
self.address,
self.width,
self.value,
self.step,
self.address & 0x07
)
}
}

#[derive(Clone, Default)]
pub struct ZiskRequired {
pub arith: Vec<ZiskRequiredOperation>,
Expand Down
Loading
Loading