-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ongoing pp #354
base: develop
Are you sure you want to change the base?
Feature/ongoing pp #354
Conversation
Add more testing Refactor function overrite Refactor GlobalExitRoot contracts for dovereign chains First testing iteration sovereign chains Review fixes Review fixes II Review fixes III Full testing coverage for sovereign contracts Added sovereign bridge features - Batch call function implementation to remap multiple tokens - Allow migrating legacy to updated tokens natively - Added weth mapped address are initializer Refactor migrateLegacyToken function Coverage tests + fix 1_genesis script + typos Fix sovereign chain deployment at docker and removed struct Add remove ger function at sovereign GER contracts Review comment and add override at initialize function Refactor gerManagerSovereigns Create batch for pessimistic networks
Update bridge at create rollup for vanilla clients Review update
Package-lock Small fix upgrade rollupManager pessimistic script
Update deploy scripts with more checks Improve upgrade presimistic script
Sovereign bridge implementation
Upgrade sp1 verifier to v3 + improve comment at bridgev2
deployment/testnet/prepareTestnet.ts
Outdated
const gasTokenFactory = await ethers.getContractFactory("ERC20", deployer); | ||
const gasTokenContract = await gasTokenFactory.deploy(gasTokenName, gasTokenSymbol); | ||
await gasTokenContract.waitForDeployment(); | ||
deployParameters.gasTokenAddress = gasTokenContract.target; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't easier to modify jsut the createRollup file?¿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same difficult I guess, I thought we decided to put it on prepareTesnet script
@@ -29,13 +29,13 @@ contract PolygonRollupManagerNotUpgraded is PolygonRollupManager { | |||
uint64 /*zkEVMForkID*/, | |||
uint64 /*zkEVMChainID*/ | |||
) external reinitializer(2) { | |||
pendingStateTimeout = _pendingStateTimeout; | |||
trustedAggregatorTimeout = _trustedAggregatorTimeout; | |||
//pendingStateTimeout = _pendingStateTimeout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could clean this contract ^^!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Remove mocked prev ler for sp1 e2e testing + updated input
Quality Gate passedIssues Measures |
This PR adds the following: