Create new rollup script #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasirv
requested review from
invocamanman,
krlosMata and
laisolizq
as code owners
ignasirv
force-pushed
the
feature/create-new-rollup
branch
2 times, most recently
from
b7f88a9 to
59ce85c
Compare
krlosMata
changed the base branch from
feature/ongoingPP
to
feature/audit-remediations
krlosMata
requested changes
Nov 27, 2024
|
Provide description in the PR comment about the changes in this PR |
ignasirv
force-pushed
the
feature/create-new-rollup
branch
3 times, most recently
from
b119c8f to
9744783
Compare
krlosMata
reviewed
Nov 29, 2024
krlosMata
reviewed
Nov 29, 2024
| }; | ||
|
|
||
| // Function to recursively convert BigInts to Numbers | ||
| function convertBigIntsToNumbers(obj) { |
There was a problem hiding this comment.
what if a bigInt is large than 2**53 - 1 (max number in JS) ?
There was a problem hiding this comment.
If it's larger than 2 ** 53 - 1 it sets the value as 2 ** 53 - 1 . It's important to know this limitation when using that util (I will add a coment)
The decoded values that are being used now with this function are "rollupTypeID", "chainID", "value". None of them should be grater than 2**53 - 1 when creating a rollup. Anyway, it's also possible to present those values as strings
ignasirv
force-pushed
the
feature/create-new-rollup
branch
5 times, most recently
from
6d4fc97 to
d5f1c8a
Compare
ignasirv
force-pushed
the
feature/create-new-rollup
branch
2 times, most recently
from
cfd7476 to
dff3f3e
Compare
ignasirv
force-pushed
the
feature/create-new-rollup
branch
from
dff3f3e to
664b0a1
Compare
ignasirv
force-pushed
the
feature/create-new-rollup
branch
from
c9d10f1 to
bcc4f01
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements: