Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getfilterchanges return value #3762

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix getfilterchanges return value #3762

wants to merge 1 commit into from

Conversation

giskook
Copy link

@giskook giskook commented Aug 12, 2024

Closes #3686

What does this PR do?

Reviewers

Main reviewers:

Codeowner reviewers:

  • @-Alice
  • @-Bob

@giskook giskook requested a review from tclemos as a code owner August 12, 2024 03:06
@cla-bot cla-bot bot added the cla-signed label Aug 12, 2024
@giskook giskook mentioned this pull request Aug 12, 2024
Merged
@tclemos tclemos self-assigned this Aug 12, 2024
@tclemos
Copy link
Contributor

tclemos commented Aug 12, 2024

hi @giskook, thanks for your contribution.
It looks like one of the tests is failing due to the change you proposed. Would you mind checking it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclemos tclemos Awaiting requested review from tclemos tclemos is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tclemos tclemos

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_getFilterLogs returns empty may cause NullPointerException (NPE) in web3j
2 participants
@giskook @tclemos