Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: attempt fixing security issues #160

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

odcey
Copy link
Contributor

@odcey odcey commented Jul 17, 2023

Description

we're having critical security issues on some dependencies
i'm investigating, mainly caused by release-it
one of the issue is on vm2 package: https://www.npmjs.com/package/vm2
but the package has been deprecated and still used on release-it, someone warned here: release-it/release-it#1024
the other issues are around semver package, also mainly in release-it package

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (code improvement)
  • Styles (adding, editing or fixing styles)
  • Unit test

How Has This Been Tested?

Please describe the steps to test.

Evidence

Please add some evidence like screenshots or records.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@rajat43 rajat43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@rajat43 rajat43 merged commit 04cadf9 into main Jul 19, 2023
5 checks passed
@jmdev3 jmdev3 deleted the build/security-upgrade-release-it branch July 25, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants