Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sdk #166

Merged
merged 15 commits into from
Jul 28, 2023
Merged

refactor: sdk #166

merged 15 commits into from
Jul 28, 2023

Conversation

jmdev3
Copy link
Contributor

@jmdev3 jmdev3 commented Jul 25, 2023

Description

Re-build squid sdk

  • re implement most of the existed methods
  • design good solution for handling cosmos and in the future more chains if needed with handlers
  • error handling, for now I just keep it simple, let's iterate once we understand how error is going to be handle at api lvl, and maybe we can share implementation with type package
  • unit test

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (code improvement)
  • Styles (adding, editing or fixing styles)
  • Unit test

How Has This Been Tested?

Please describe the steps to test.

Evidence

Please add some evidence like screenshots or records.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@0x1NotMe 0x1NotMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove package-lock.json

package.json Outdated Show resolved Hide resolved
@0x1NotMe
Copy link
Contributor

We should at least complete linting ?

@jmdev3 jmdev3 requested a review from 0x1NotMe July 27, 2023 16:05
@jmdev3 jmdev3 merged commit 108b9c4 into main-v2 Jul 28, 2023
3 of 5 checks passed
@jmdev3 jmdev3 deleted the refactor/sdk branch July 28, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants