Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returns all tokens with zero balance when rpc call fails #331

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

genaroibc
Copy link
Contributor

Description

When getting evm balances, if the RPC call fails (usually the rpc is broken) the sdk returns an empty array for tokens, instead of tokens with balance: 0. This ends up in the widget displaying an empty tokens list:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

After the fix, the tokens load correctly (the underlying issue is not fixed though, the rpc is down)
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@genaroibc genaroibc merged commit 9ed0d84 into main Aug 19, 2024
3 checks passed
@genaroibc genaroibc deleted the fix/empty-tokens-array-when-rpc-call-fails branch August 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants