Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ‘· github-actions prod.yaml GTM ν™˜κ²½ λ³€μˆ˜ μΆ”κ°€ 및 쀑볡 λΉŒλ“œ 둜직 제거 #107

Merged
merged 1 commit into from
Oct 1, 2024
Merged

πŸ‘· github-actions prod.yaml GTM ν™˜κ²½ λ³€μˆ˜ μΆ”κ°€ 및 쀑볡 λΉŒλ“œ 둜직 제거 #107

merged 1 commit into from
Oct 1, 2024

Conversation

TopazKang
Copy link
Contributor

πŸ“ κ°œμš”

  • ν”„λ‘œλ•μ…˜ μ„œλ²„μ˜ gtm λ™μž‘μ„ μœ„ν•œ 둜직 μΆ”κ°€, μ˜λ―Έμ—†λŠ” λΉŒλ“œ 둜직 제거

✨ λ³€κ²½ 사항

  • μ½”λ“œλ‚˜ κΈ°λŠ₯의 μ£Όμš” λ³€κ²½ 사항을 μ„€λͺ…ν•©λ‹ˆλ‹€.

    • ✨ prod.yaml에 도컀 이미지 λΉŒλ“œμ‹œ μ‚¬μš©λ˜λŠ” ν™˜κ²½λ³€μˆ˜ μΆ”κ°€
    • ✨ dev.yaml & prod.yaml νŒŒμΌμ— λŒ€ν•œ 의미 없이 μ€‘μ²©λ˜λŠ” λΉŒλ“œ 둜직의 제거

πŸ”— κ΄€λ ¨ 이슈

  • 이 PRκ³Ό κ΄€λ ¨λœ 이슈 번호λ₯Ό μ—°κ²°ν•©λ‹ˆλ‹€. (μ—†μœΌλ©΄ μƒλž΅)
    • 예: closes #123, resolves #456

πŸ“Έ μŠ€ν¬λ¦°μƒ· (μ˜΅μ…˜)

  • UI λ³€κ²½ 사항이 μžˆλŠ” 경우 μŠ€ν¬λ¦°μƒ·μ„ ν¬ν•¨ν•©λ‹ˆλ‹€.

ℹ️ μ°Έκ³  사항

  • 리뷰어가 μ•Œ ν•„μš”κ°€ μžˆλŠ” μΆ”κ°€ μ •λ³΄λ‚˜ λ¬Έμ„œ, μ°Έκ³  링크λ₯Ό ν¬ν•¨ν•©λ‹ˆλ‹€.

sen2y
sen2y approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@sen2y sen2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ :>

@sen2y sen2y merged commit 3748066 into dev Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sen2y sen2y sen2y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TopazKang @sen2y