Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/updated linting #144

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Feature/updated linting #144

merged 8 commits into from
Oct 26, 2023

Conversation

darylldoyle
Copy link
Contributor

Description of the Change

This PR updates the linting within the repo to lint CSS/JS and PHP using the 10up standards.

  • It adds in ESlint and StyleLint from the 10up toolkit.
  • It adds lint-staged and husky to ensure that future PRs align with the code styles.
  • It updates the linting Github Action to use the new configs
  • It fixes a bunch of PHPCS errors that were being flagged.

How to test the Change

  • Smoketest the plugin.
  • Run linters
    • npm run lint-js
    • npm run lint-style
    • composer run lint

Changelog Entry

  • Added - Additional linting.
  • Changed - The linting standards to align with the 10up standards.
  • Fixed - PHPCS errors/warnings.

Credits

Props @darylldoyle

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@darylldoyle darylldoyle added the enhancement New feature or request label Oct 26, 2023
@darylldoyle darylldoyle self-assigned this Oct 26, 2023
@darylldoyle darylldoyle merged commit 07d9f6b into develop Oct 26, 2023
3 checks passed
@darylldoyle darylldoyle deleted the feature/updated-linting branch October 26, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants