Remove urlencode from srcset calculation function #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change fixes an issue with URLencoding we've seen in our sites. Blob URLs are being encoded in the
windows_azure_storage_wp_calculate_image_srcset
function which causes wrong URLs when displaying those in the browser.Removing those encoding, fixes the issue and return a valid URL
How to test the Change
wp_get_attachment_image
. This will cause, the plugin hooks in through thewp_calculate_image_srcset
filterChangelog Entry
Credits
Props @hugosolar
Checklist: