-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PDF replacement feature #220
Merged
jeffpaul
merged 8 commits into
10up:develop
from
hugosolar:feature/add-media-replacement-feature
Apr 23, 2024
Merged
Add PDF replacement feature #220
jeffpaul
merged 8 commits into
10up:develop
from
hugosolar:feature/add-media-replacement-feature
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
colegeissinger
and removed request for
dkotter and
jeffpaul
April 1, 2024 21:23
@hugosolar looks like failing e2e tests, could you check on those please? |
@jeffpaul I think this is related to the constants passed to Cypress related to the account name & key On a previous PR, I remember we faced the same situation and @Sidsector9 was able to fix it |
rickalee
requested changes
Apr 17, 2024
@hugosolar Some feedback to address and need to address the E2E tests. |
rickalee
approved these changes
Apr 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We've seen some situations where users want to replace a PDF file with an updated version (CV for example)
This PR adds to the plugin the ability to replace pdf files (for now) using a new method to copy the blob and replace it with the uploaded file.
There's a new method called
copy_media_to_blob_storage
in helpers and also a newcopy_blob
method in the API clientthis uses the Copy Blob operation described here: https://learn.microsoft.com/en-us/rest/api/storageservices/Copy-Blob
There's also a new button added in the media uploader that holds the workflow to replace the document
Open discussion for addressing images
We should have a discussion on how to approach image replacements since an image of a different orientation can be uploaded and image sizes of the image to be replaced won't match, so I was thinking on two paths
How to test the Change
To test this:
wp-admin/upload.php
)Changelog Entry
Credits
@hugosolar
Checklist: