Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix content type issue defaulting to octet-stream #224

Merged

Conversation

hugosolar
Copy link
Contributor

@hugosolar hugosolar commented Apr 15, 2024

Description of the Change

This PR ensures that the blob is being sent to the storage with the proper content type as we're experiencing issues with some containers defaulting the content type to application/octet-stream
With this fix, we're not leaving the default content type but sending the file content type directly to the createBlockBlob() function through the $options parameters

Fixes #210

How to test the Change

  • Using the plugin, upload an image to the blob container
  • Using Azure storage explores, verify the proper content type is being set in the blob container

Changelog Entry

Fixed - Ensure we send the proper content type when creating the Block Blob in the container.

Credits

@hugosolar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@hugosolar hugosolar self-assigned this Apr 15, 2024
@jeffpaul jeffpaul removed their request for review April 15, 2024 20:57
@jeffpaul jeffpaul added this to the 4.5.0 milestone Apr 15, 2024
@jeffpaul jeffpaul merged commit 01fc36e into 10up:develop Apr 23, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants