Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config scope and tmp dir creation #90

Open
wants to merge 3 commits into
base: copie-session
Choose a base branch
from

Conversation

sjvrijn
Copy link

@sjvrijn sjvrijn commented Jul 30, 2024

@12rambau
Copy link
Owner

how will it continue to work at function scope if the config file fixture is session scoped ?

@sjvrijn
Copy link
Author

sjvrijn commented Aug 1, 2024

Setting the config scope to session means it's only generated once per session, i.e., the result is reused for all subsequent calls. This seems to work fine for pytest-cookies: https://github.com/hackebrot/pytest-cookies/blob/28492af5bba1da3a2bed19389f96584e51c1e08f/src/pytest_cookies/plugin.py#L119

@sjvrijn
Copy link
Author

sjvrijn commented Aug 19, 2024

@12rambau, are there any other questions you have about this, or is there anything else I can do?

@12rambau
Copy link
Owner

I just need to find time to perform my OSS duties, I like this repository and use it a lot I'll let you know if anything is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants